Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(events): configure schema discovery on event bus #32739

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rrhodes
Copy link
Contributor

@rrhodes rrhodes commented Jan 4, 2025

This is a draft PR whilst we debate in the associated GitHub Issue some concerns about future breaking changes. We may require an L2 Schema Discoverer construct before proceeding further with this change.

Issue

Closes #26480.

Reason for this change

Ease the developer experience to configure schema discovery on an Event Bus. Follows the same pattern as Archives.

Description of changes

Subject to change.

Description of how you validated changes

Unit test coverage added for schema discovery. No changes made to integration tests.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team January 4, 2025 17:32
@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 valued-contributor [Pilot] contributed between 6-12 PRs to the CDK labels Jan 4, 2025
@rrhodes rrhodes marked this pull request as ready for review January 4, 2025 17:33
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@rrhodes rrhodes changed the title feat(aws-events): configure schema discovery on event bus feat(events): configure schema discovery on event bus Jan 4, 2025
Copy link

codecov bot commented Jan 4, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.96%. Comparing base (dd6a2f4) to head (33d12b2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #32739      +/-   ##
==========================================
- Coverage   66.96%   66.96%   -0.01%     
==========================================
  Files         329      331       +2     
  Lines       18667    18672       +5     
  Branches     3260     3260              
==========================================
+ Hits        12501    12504       +3     
- Misses       5839     5841       +2     
  Partials      327      327              
Flag Coverage Δ
suite.unit 66.96% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.71% <ø> (ø)
packages/aws-cdk-lib/core 82.09% <ø> (ø)

@rrhodes rrhodes force-pushed the feat/enable-event-bus-schema-discovery branch from 8e57a94 to 33d12b2 Compare January 4, 2025 18:10
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 4, 2025 18:13

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 4, 2025
@rrhodes rrhodes force-pushed the feat/enable-event-bus-schema-discovery branch from 33d12b2 to 1d48e14 Compare January 5, 2025 12:46
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 1d48e14
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@rrhodes rrhodes marked this pull request as draft January 5, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. valued-contributor [Pilot] contributed between 6-12 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-events: Enable schema discovery for Event Bus
2 participants