-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(events): configure schema discovery on event bus #32739
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #32739 +/- ##
==========================================
- Coverage 66.96% 66.96% -0.01%
==========================================
Files 329 331 +2
Lines 18667 18672 +5
Branches 3260 3260
==========================================
+ Hits 12501 12504 +3
- Misses 5839 5841 +2
Partials 327 327
Flags with carried forward coverage won't be shown. Click here to find out more.
|
8e57a94
to
33d12b2
Compare
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
33d12b2
to
1d48e14
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This is a draft PR whilst we debate in the associated GitHub Issue some concerns about future breaking changes. We may require an L2 Schema Discoverer construct before proceeding further with this change.
Issue
Closes #26480.
Reason for this change
Ease the developer experience to configure schema discovery on an Event Bus. Follows the same pattern as Archives.
Description of changes
Subject to change.
Description of how you validated changes
Unit test coverage added for schema discovery. No changes made to integration tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license