-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cli): refactor cli.ts to use UserInput
#32760
Draft
kaizencc
wants to merge
19
commits into
main
Choose a base branch
from
conroy/refact
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+415
−414
Draft
Changes from 2 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
19d2e41
chore(cli): cli arguments with "count: true" are generated as number …
kaizencc 2cc8fba
chore(cli): refactor cli.ts to use CliArguments
kaizencc 4bc293d
builds with test failures
kaizencc 76281b7
Merge branch 'main' into conroy/refact
kaizencc b4757bf
still builds
kaizencc 957f079
more building
kaizencc d3e9d97
Merge branch 'conroy/refact' of https://github.com/aws/aws-cdk into c…
kaizencc 2ea4181
use settinsg
kaizencc a5e6e8c
small chagne
kaizencc ed19731
oneline
kaizencc 8564109
updates
kaizencc 145850f
finish merge
kaizencc 64e4404
delete extra file
kaizencc 3da904c
builds now
kaizencc ecef343
fixes the build
kaizencc ad76f1f
still builds, better refacotrs some places
kaizencc 03fe7d6
more updates
kaizencc f247927
Merge branch 'main' into conroy/refact
kaizencc 0bd551d
Merge branch 'conroy/refact' of https://github.com/aws/aws-cdk into c…
kaizencc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im reverting these changes. tying them as
any
as they were before. can revisit in separate PR if we want to handle all cases where we turn a string into an enum in a better way