feat(s3): throw ValidationError instead of untyped errors
#33031
+95
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrgrain
added
pr-linter/exempt-readme
mrgrain
changed the title
ValidationErrorValidationError instead of untyped errors
aws-cdk-automation
added
the
pr/needs-maintainer-review
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #33031 +/- ##
==========================================
+ Coverage 81.46% 81.49% +0.02%
==========================================
Files 224 224
Lines 13748 13755 +7
Branches 2412 2413 +1
==========================================
+ Hits 11200 11209 +9
Misses 2273 2273
+ Partials 275 273 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
kaizencc
approved these changes
Jan 21, 2025
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
aws-s3for #32569Description of changes
Added an
UnscopedValidationErrorfor situations where now scope is available. This is to be used sparsely as it's less useful for users.Describe any new or updated permissions being added
n/a
Description of how you validated changes
Existing tests. Exemptions granted as this is basically a refactor of existing code.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license