Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(SearchableEncryption): disable shared cached #1507

Merged
merged 5 commits into from
Dec 16, 2024
Merged

fix(SearchableEncryption): disable shared cached #1507

merged 5 commits into from
Dec 16, 2024

Conversation

texastony
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@texastony texastony marked this pull request as ready for review December 16, 2024 19:28
@texastony texastony requested a review from a team as a code owner December 16, 2024 19:28
ajewellamz
ajewellamz previously approved these changes Dec 16, 2024
View reviewed changes
@texastony texastony mentioned this pull request Dec 16, 2024
Open
RitvikKapila
RitvikKapila approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@RitvikKapila RitvikKapila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RitvikKapila RitvikKapila mentioned this pull request Dec 16, 2024
Closed
@texastony
Copy link
Contributor Author

I have never seen this test fail:

software.amazon.cryptography.examples.migration.awsdbe.encrypttable.TestEncryptExistingTable > TestEncryptExistingTable FAILED
    java.lang.AssertionError
        at software.amazon.cryptography.examples.migration.awsdbe.encrypttable.TestEncryptExistingTable.EncryptExistingTable(TestEncryptExistingTable.java:179)
        at software.amazon.cryptography.examples.migration.awsdbe.encrypttable.TestEncryptExistingTable.TestEncryptExistingTable(TestEncryptExistingTable.java:197)

I wonder what is up...

@texastony texastony merged commit ffc67be into main Dec 16, 2024
39 checks passed
@texastony texastony deleted the tony/fix-no-shared-cache-on-se branch December 16, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RitvikKapila RitvikKapila RitvikKapila approved these changes

@ajewellamz ajewellamz ajewellamz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@texastony @RitvikKapila @ajewellamz