feat: EncryptItem and DecryptItem #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lavaleri
reviewed
Dec 16, 2022
DynamoDbItemEncryptor/src/AwsCryptographyDynamoDbItemEncryptorOperations.dfy
Outdated
Show resolved
Hide resolved
DynamoDbItemEncryptor/src/AwsCryptographyDynamoDbItemEncryptorOperations.dfy
Outdated
Show resolved
Hide resolved
lavaleri
reviewed
Dec 16, 2022
| @@ -163,8 +157,7 @@ Each key-value pair MUST be serialized as: | |||
| | Value Length | 4 | | |||
| | Map Value | Variable | | |||
|
|
|||
| This sequence MUST NOT contain duplicate [Map Keys](#map-key). | |||
There was a problem hiding this comment.
Similar to how you have added "Binary Sets MUST NOT contain duplicate entries" above. I want to reintroduce this as a MUST requirement here.
There was a problem hiding this comment.
I'll put it back, but I don't know how to Duvet it.
lavaleri
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
EncryptItem and DecryptItem
Very little is testable right now, but I've added as much Duvet coverage as I could.
Also finished Duvet coverage for DynamoToStruct.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.