Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport v3.1.x #588

Merged
merged 5 commits into from
Nov 15, 2023
Merged

Backport v3.1.x #588

merged 5 commits into from
Nov 15, 2023

Conversation

seebees
Copy link
Contributor

@seebees seebees commented Nov 15, 2023

Alternate back-port of 3.1.x

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@seebees seebees requested a review from a team as a code owner November 15, 2023 19:47
seebees and others added 4 commits November 15, 2023 11:56
#560)

DB-ESDK for DynamoDB supports SIGN_ONLY and ENCRYPT_AND_SIGN attribute actions. In version 3.1.0 and below, when a Set type is assigned a SIGN_ONLY attribute action, there is a chance that signature validation of the record containing a Set will fail on read, even if the Set attributes contain the same values. The probability of a failure depends on the order of the elements in the Set combined with how DynamoDB returns this data, which is undefined.

This update addresses the issue by ensuring that any Set values are canonicalized in the same order while written to DynamoDB as when read back from DynamoDB.

See: https://github.com/aws/aws-database-encryption-sdk-dynamodb-java/tree/v3.1.1/DecryptWithPermute for additional details
The examples relied on order that has been fixed
ajewellamz
ajewellamz previously approved these changes Nov 15, 2023
Copy link
Contributor

@lavaleri lavaleri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also update the java version in project.properties.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@seebees seebees merged commit 8f8f37f into main Nov 15, 2023
19 checks passed
@seebees seebees deleted the backport-v3.1.x branch November 15, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants