Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link to file that no longer exists in amazon-eks-ami repo #577

Closed
wants to merge 1 commit into from

Conversation

brc
Copy link

@brc brc commented Sep 5, 2024

Issue #, if available:

n/a

Description of changes:

Remove a broken link to a file that no longer exists in another repo.

Instead, link to a Markdown page in that same repo which describes how to generate aforementioned file.

(This file is generated by a Make target in amazon-vpc-cni-k8s repo using:)

 make generate-limits

Feels less brittle linking to that page which describes the steps rather than duplicating the steps here (lest they become outdated again).

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This file is now generated by a Make target in amazon-vpc-cni-k8s repo:

    make generate-limits
@brc brc requested a review from a team as a code owner September 5, 2024 23:19
@brc
Copy link
Author

brc commented Sep 10, 2024

Hi @svennam92, please approve.

@brc
Copy link
Author

brc commented Sep 11, 2024

bump @bradwatsonaws

@bradwatsonaws
Copy link
Contributor

Sorry @brc I don't maintain the other repo and can't approve PRs here either.

@svennam92
Copy link
Collaborator

Please re-open this PR against the asciidoc format we've migrated to (folder: latest/bpg)

@svennam92 svennam92 closed this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants