Add .NET 8 version of the Lambda Test Tool and remove .NET Core 3.1 and .NET 5 versions. #1601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tools/LambdaTestTool/src/Amazon.Lambda.TestTool.BlazorTester/Pages/Documentation.razor
Show resolved
Hide resolved
ashishdhingra
approved these changes
Nov 1, 2023
ashovlin
approved these changes
Nov 2, 2023
ronanj2
reviewed
Nov 8, 2023
There was a problem hiding this comment.
nit: perhaps remove these lines from README since these TFMs are getting removed in this PR
https://github.com/aws/aws-lambda-dotnet/pull/1601/files#diff-238787c578ef0bb3232fb617b55904f9ad9ff6dca823008d99a4d23c2ae9cc46R33-R35
I thought about removing them from the table but since the packages are still available on NuGet I left them there but with the (Deprecated) suffix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Add a .NET 8 version of the deploy tool. This involved
buildtools\build.projto package new .NET 8 version and stop packaging .NET Core 3.1 and .NET 5 version.net8.0as target framework in projectsnetcoreapp3.1andnet5.0as target frameworks in projects.#ifused for branding as .NET 8ManifestEmbeddedFileProviderto serve the static files. In .NET 8 Blazor made changes to how the file providers were setup so I needed to add a new .NET 8+ code in theStartupclass for setting up theManifestEmbeddedFileProvider.The test project and all of the test lambda function projects had to be refactored to get this tested. Before all of the were testing against .NET Core 3.1 except for a few tests in a .NET 6 project for source generator. I refactored the tests to have a single test project that multi targets .NET 6 and 8 and moved all of the tests under that projects. So now all of the tests are run for both 6 and 8. All of the sample test function projects were moved from a .NET Core 3.1 specific folder to a generic
tests/LambdaFunctionsfolder and all of the function projects multi target .NET 6 and 8. Since no new features were added no new tests were added or changed other then to work in this new structured.The tests for the project had to be refactored they were all targeting .NET Core 3.1. This involved a lot of moving test files around. There were no changes done to the tests files other then put them under a single mutli target
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.