Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverity fixes for P173127397 #2014

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Coverity fixes for P173127397 #2014

merged 2 commits into from
Dec 3, 2024

Conversation

skmcgrail
Copy link
Member

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@skmcgrail skmcgrail requested a review from a team as a code owner November 25, 2024 23:59
Copy link
Contributor

@smittals2 smittals2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like unistd.h isn't available on windows, might need closesocket() from winsock2.h?

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 78.67%. Comparing base (b345535) to head (399c078).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
tool/client.cc 0.00% 10 Missing ⚠️
tool/transport_common.cc 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2014      +/-   ##
==========================================
- Coverage   78.68%   78.67%   -0.01%     
==========================================
  Files         598      598              
  Lines      103321   103329       +8     
  Branches    14687    14685       -2     
==========================================
- Hits        81296    81293       -3     
- Misses      21375    21385      +10     
- Partials      650      651       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

justsmth
justsmth previously approved these changes Nov 26, 2024
@skmcgrail skmcgrail merged commit 0931fe2 into aws:main Dec 3, 2024
116 of 119 checks passed
@skmcgrail skmcgrail deleted the P173127397 branch December 3, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants