-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump CDK to 2.114.1 #1154
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Caden Marofke <[email protected]>
50999c6
to
0254f6a
Compare
jericht
previously approved these changes
Dec 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
jusiskin
previously approved these changes
Dec 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this large migration @marofke!
jericht
requested changes
Dec 14, 2023
… 2.114.1 Signed-off-by: Caden Marofke <[email protected]>
69d81ac
to
211eaed
Compare
jericht
approved these changes
Dec 14, 2023
jusiskin
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We needed to update the version of CDK used by RFDK.
Solution
Ran
npm-upgrade
for all relevantpackage.json
files, bumping everything that made sense. I had to make a few minor tweaks to tests in order for them to build properly, and changed some deprecated function calls to get rid of warnings. I also took this opportunity to clean up the dependabot ignorelist for CDK-related packages. Also updated the python examples' CDK version since that was behind since the last upgrade.Testing
yarn run build
All-In-Infrastructure-Basic
stack in my AWS account, confirmed it spun up and tore down successfullyBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license