Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump CDK to 2.114.1 #1154

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Conversation

marofke
Copy link
Contributor

@marofke marofke commented Dec 13, 2023

Problem

We needed to update the version of CDK used by RFDK.

Solution

Ran npm-upgrade for all relevant package.json files, bumping everything that made sense. I had to make a few minor tweaks to tests in order for them to build properly, and changed some deprecated function calls to get rid of warnings. I also took this opportunity to clean up the dependabot ignorelist for CDK-related packages. Also updated the python examples' CDK version since that was behind since the last upgrade.

Testing

  • yarn run build
  • Deployed the All-In-Infrastructure-Basic stack in my AWS account, confirmed it spun up and tore down successfully

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@marofke marofke force-pushed the marofke/cdk-2.114.1-update branch from 50999c6 to 0254f6a Compare December 13, 2023 21:47
@marofke marofke requested a review from jusiskin December 13, 2023 23:01
@jericht jericht self-requested a review December 14, 2023 16:57
jericht
jericht previously approved these changes Dec 14, 2023
Copy link
Contributor

@jericht jericht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jusiskin
jusiskin previously approved these changes Dec 14, 2023
Copy link
Contributor

@jusiskin jusiskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this large migration @marofke!

@jusiskin jusiskin added the dependencies This issue is a problem in a dependency. label Dec 14, 2023
@marofke marofke merged commit 493f561 into mainline Dec 14, 2023
3 checks passed
@marofke marofke deleted the marofke/cdk-2.114.1-update branch December 14, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies This issue is a problem in a dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants