Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add kinesis dependency to boto3-stubs in base.txt #6064

Merged
merged 7 commits into from
Oct 12, 2023

Conversation

hnnasit
Copy link
Contributor

@hnnasit hnnasit commented Oct 10, 2023

Which issue(s) does this change fix?

N/A

Why is this change necessary?

This change is necessary to add kinesis boto3 stubs which will be used for remote invoke Kinesis streams. The GitHub action that runs and validates reproducible does not run on PRs created from forked branches. This change is necessary for the PR #6063

How does it address the issue?

Adds kinesis boto3-stub dependency

What side effects does this change have?

N/A

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hnnasit hnnasit closed this Oct 10, 2023
@hnnasit hnnasit reopened this Oct 10, 2023
@hnnasit hnnasit marked this pull request as ready for review October 10, 2023 21:42
@hnnasit hnnasit requested a review from a team as a code owner October 10, 2023 21:42
@hnnasit hnnasit requested review from hawflau and moelasmar October 10, 2023 21:42
@hnnasit hnnasit enabled auto-merge October 12, 2023 20:22
@hnnasit hnnasit added this pull request to the merge queue Oct 12, 2023
Merged via the queue into develop with commit 9f182f0 Oct 12, 2023
@hnnasit hnnasit deleted the add-kinesis-boto3-stubs branch October 18, 2023 16:42
moelasmar pushed a commit to moelasmar/aws-sam-cli that referenced this pull request Oct 22, 2023
* Add kinesis dependency to boto3-stubs in  base.txt

* Update reproducibles: update-reproducible-linux-reqs

* Update reproducibles: update-reproducible-mac-reqs

* Update reproducibles: update-reproducible-win-reqs

---------

Co-authored-by: GitHub Action <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants