Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): Enable build tests #6099

Merged
merged 1 commit into from
Oct 17, 2023
Merged

chore(tests): Enable build tests #6099

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions tests/integration/buildcmd/test_build_in_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
LOG = logging.getLogger(__name__)


@skip("Building in source option is not exposed yet. Stop skipping once it is.")
class TestBuildCommand_BuildInSource_Makefile(BuildIntegProvidedBase):
template = "template.yaml"
is_nested_parent = False
Expand Down Expand Up @@ -50,9 +49,9 @@ def test_builds_successfully_with_makefile(self, build_in_source, new_file_shoul
)


@skip("Building in source option is not exposed yet. Stop skipping once it is.")
class TestBuildCommand_BuildInSource_Esbuild(BuildIntegEsbuildBase):
is_nested_parent = False
template = "template_with_metadata_esbuild.yaml"

def setUp(self):
super().setUp()
Expand All @@ -73,7 +72,6 @@ def tearDown(self):
)
@pytest.mark.flaky(reruns=3)
def test_builds_successfully_without_local_dependencies(self, build_in_source, dependencies_expected_in_source):
self.template_path = os.path.join(self.test_data_path, "template_with_metadata.yaml")
codeuri = os.path.join(self.test_data_path, "Esbuild", "Node")
self.source_directories = [codeuri]

Expand All @@ -92,7 +90,6 @@ def test_builds_successfully_without_local_dependencies(self, build_in_source, d

@pytest.mark.flaky(reruns=3)
def test_builds_successfully_with_local_dependency(self):
self.template_path = os.path.join(self.test_data_path, "template_with_metadata.yaml")
codeuri = os.path.join(self.test_data_path, "Esbuild", "NodeWithLocalDependency")
self.source_directories = [codeuri]
runtime = "nodejs16.x"
Expand Down
Loading