Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate architecture before trying to pull the build image #6118

Closed
wants to merge 1 commit into from

Conversation

mndeveci
Copy link
Contributor

Which issue(s) does this change fix?

#6110

Why is this change necessary?

AWS Lambda Function's architecture is used during building inside container to decide what would be the tag for the container (either latest-x86_64 or latest-arm64). Today there is no validation with this field, which ends up in en error while trying to pull the image.

How does it address the issue?

This change addresses that issue by adding validation of the architecture before pulling the image.

What side effects does this change have?

N/A

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants