Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding dotnet build method that is version agnostic #7495

Merged
merged 4 commits into from
Oct 18, 2024

Conversation

Beau-Gosse-dev
Copy link
Contributor

Tested with SAM_CLI_DEV=1 pytest tests/integration -k "test_dotnet_al2_2_provided_al2"
1 passed, 2102 deselected in 17.34s

Which issue(s) does this change fix?

#7463

Why is this change necessary?

See issue

How does it address the issue?

Adds dotnet build method

What side effects does this change have?

dotnet7 build method is now unnecessary, but kept for backwards compatibility.

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Beau-Gosse-dev Beau-Gosse-dev requested a review from a team as a code owner September 20, 2024 19:02
@github-actions github-actions bot added area/build sam build command pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Sep 20, 2024
@lucashuy
Copy link
Contributor

Thanks for adding the flag for a generic dotnet method. Looks like you might just need to run the linter with make format, and a sanity check with make pr to pass the Github Actions.

@lucashuy lucashuy removed the stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. label Sep 25, 2024
@Beau-Gosse-dev
Copy link
Contributor Author

Thanks. make format is working now and make pr has only 1 unrelated test failing:

FAILED tests/unit/commands/local/cli_common/test_invoke_context.py::TestInvokeContext_add_account_id_to_global::test_must_work_with_no_token - AssertionError: {'AWS::AccountId': '9**********1'} is not None
=========== 1 failed

@Beau-Gosse-dev
Copy link
Contributor Author

Looks like the test failure is unrelated: FAILED tests/integration/init/test_init_command.py::TestBasicInitCommand::test_init_command_go_provided_image - AssertionError: 1 != 0

Copy link
Contributor

@hawflau hawflau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution!

@mndeveci mndeveci enabled auto-merge October 18, 2024 20:15
@mndeveci mndeveci changed the title Adding dotnet build method that is version agnostic feat: adding dotnet build method that is version agnostic Oct 18, 2024
@mndeveci mndeveci added this pull request to the merge queue Oct 18, 2024
Merged via the queue into aws:develop with commit ab95fdb Oct 18, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build sam build command pr/external
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants