Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and simplify logic in sdksCommon cmake script #3251

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SergeyRyabinin
Copy link
Contributor

@SergeyRyabinin SergeyRyabinin commented Jan 15, 2025

Issue #, if available:
cmake logic depends on c2j file list in tools/code-generation/api-descriptions
This does not make much sense anymore since

  1. generated clients are all located under generated/src source tree
  2. c2j file renaming logic is extracted and duplicated within the code generation script run_code_generation.py, so additional logic of datetime extraction, c2j filename renaming and etc is not actually required in the cmake script.

i.e. cmake can rely solely on the source tree

tested by building both full main and this branch and by comparing the cmake output and resulting build/install directories, i.e.

tree ~/sdk-install-main-clean/ > mainTree.log
tree ~/sdk-install-cmake-refactor/ > refactorTree.log
diff mainTree.log refactorTree.log

Description of changes:

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@SergeyRyabinin SergeyRyabinin marked this pull request as ready for review January 16, 2025 17:46
@SergeyRyabinin SergeyRyabinin changed the title [draft] Refactor and simplify logic in sdksCommon cmake script Refactor and simplify logic in sdksCommon cmake script Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants