Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lru-cache): add typed-array based LRUCache implementation #2406

Closed
wants to merge 4 commits into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented May 19, 2021

Issue

Internal JS-2612

Description

Adds typed-array based LRUCache implementation.

This PR would be made ready for review once it's cleared for Open Sourcing.

Testing

Unit tests


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr marked this pull request as draft May 19, 2021 16:52
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@6fd95e3). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2406   +/-   ##
=======================================
  Coverage        ?   59.20%           
=======================================
  Files           ?      492           
  Lines           ?    26298           
  Branches        ?     6239           
=======================================
  Hits            ?    15571           
  Misses          ?    10727           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fd95e3...407f1bf. Read the comment docs.

@trivikr

This comment has been minimized.

@trivikr
Copy link
Member Author

trivikr commented May 28, 2021

Closing without merge, as we decided to use mnemonist/LRUCache after discussing with Open Source team

@trivikr trivikr closed this May 28, 2021
@trivikr trivikr deleted the lru-cache branch May 28, 2021 18:02
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants