Fixes XML Map unmarhsalling to handle any key-value pair and xmlnamespaces #3652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterrsongg
force-pushed
the
petesong/xml-name-protocol-tests
branch
from
99a3d39 to
6cad481
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is possible for a service to specify a different key and value name in the model via "locationName". This PR removes the hardcoded reference to "key" and "value" and instead we pass in the modeled key & value name from the model. This also fixes an issue with unmarshalling a a key / value pair that has a namespace attached to it.
Motivation and Context
Fixes 8 protocol tests.
Testing
DRY RUN 5b12205f-6ab4-4c59-81a0-f045ed954fca
Screenshots (if appropriate)
Types of changes
Checklist
License