Add exception when signature generation fails

aws · Dec 5, 2022 · ce21d37 · ce21d37
1 parent 28daf91
commit ce21d37
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/.changes/nextrelease b/.changes/nextrelease
@@ -0,0 +1,7 @@
+[
+    {
+        "type": "enhancement",
+        "category": "CloudFront",
+        "description": "Throw exception when an empty signature for signed url is generated."
+    }
+]
diff --git a/src/CloudFront/Signer.php b/src/CloudFront/Signer.php
@@ -72,6 +72,7 @@ public function __destruct()
      * @return array The values needed to construct a signed URL or cookie
      * @throws \InvalidArgumentException  when not provided either a policy or a
      *                                    resource and a expires
+     * @throws \RuntimeException when generated signature is empty
      *
      * @link http://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/private-content-signed-cookies.html
      */
@@ -115,6 +116,14 @@ private function sign($policy)
         $signature = '';
         openssl_sign($policy, $signature, $this->pkHandle);
 
+        if(empty($signature)) {
+            $errorMessages = [];
+            while(($newMessage = openssl_error_string()) !== false){
+                $errorMessages[] = $newMessage;
+            }
+            throw new \RuntimeException(implode("\n",$errorMessages));
+        }
+
         return $signature;
     }