feat: remove paragonie/random_compat dev dependency #3071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing the paragonie/random_compat dev dependency, because it is unnecessary, given the fact that the AWS SDK requires PHP 7.2. PHP 7.0+ guarantees the existence of the CSPRNG. This cleans up the list of dependencies and reduces unnecessary network traffic. Fixes aws#3020
ziegenberg
force-pushed
the
remove-paragonie-random_compat-dev-dependency
branch
from
6737be6 to
afa705f
Compare
stobrien89
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
Thanks for the contribution, @ziegenberg! Missed this when I was cleaning up dependencies for the < 8.1 deprecation.
|
Hi @stobrien89, thx for accepting my PR. I would also appreciate it if you took a quick glance at #3072. Greetings, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#3020
Description of changes:
Removing the paragonie/random_compat dev dependency, because it is unnecessary, given the fact that the AWS SDK requires PHP 7.2. PHP 7.0+ guarantees the existence of the CSPRNG.
This cleans up the list of dependencies and reduces unnecessary network traffic.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.