chore: fix incorrect comparison operators #195
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes comparisons to use identity-comparison (
is
) for the singleton None, and value-comparison (==
) for strings.Why is the change necessary?
Python strings do not guarantee object identity for equal strings, so comparing
self.type
against a string usingis
might not have the intended effect. (In practice, since both values are short constant string literals from the same source file, it'll work … but it's bad practice, and generates both runtime warnings and linter warnings.)Using
is not None
instead of!= None
is less important, but it's accepted Python style to useis
/is not
for the None singleton, and linters throw warnings on this as well.Solution
How was this change tested?
tox tests/unit
has the same number of failures after this change as before.Pull Request Checklist
Please check all boxes (including N/A items)
Testing
Documentation
Title and description
Fixes #xxx
(no issue created for this PR)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.