Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow to deprecate SDK version #659

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Add workflow to deprecate SDK version #659

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions .github/workflows/deprecate_version.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
name: Deprecate X-Ray Node SDK Version
on:
workflow_dispatch:

jobs:
deprecate_xray_node_sdk_version:
name: Deprecate X-Ray Node SDK version in NPM registry
runs-on: ubuntu-latest
steps:
- name: Setup Node
uses: actions/setup-node@v1
with:
node-version: '16.x'
registry-url: 'https://registry.npmjs.org'

- run: npm install -g [email protected]

- name: Deprecate Version 3.7.0
run: |
npm deprecate [email protected] "3.7.0 is deprecated due to known issue in Lambda"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue that we can link to in the deprecation message for further clarity?

Copy link
Contributor Author

@jj22ee jj22ee Jun 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No public issue currently exists.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a couple here:
#654
#655

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these not why we are deprecating 3.7.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We found the issue locally first, but you are right, these are the same issue.

npm deprecate [email protected] "3.7.0 is deprecated due to known issue in Lambda"
npm deprecate [email protected] "3.7.0 is deprecated due to known issue in Lambda"
npm deprecate [email protected] "3.7.0 is deprecated due to known issue in Lambda"
npm deprecate [email protected] "3.7.0 is deprecated due to known issue in Lambda"
npm deprecate [email protected] "3.7.0 is deprecated due to known issue in Lambda"
npm deprecate [email protected] "3.7.0 is deprecated due to known issue in Lambda"
npm deprecate [email protected] "3.7.0 is deprecated due to known issue in Lambda"
npm deprecate [email protected] "3.7.0 is deprecated due to known issue in Lambda"
npm deprecate [email protected] "3.7.0 is deprecated due to known issue in Lambda"
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
Loading