Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape dollar sign (that is used for populating from shell env var) in manifest #5532

Closed
Lou1415926 opened this issue Dec 5, 2023 · 2 comments · Fixed by #5516
Closed

Escape dollar sign (that is used for populating from shell env var) in manifest #5532

Lou1415926 opened this issue Dec 5, 2023 · 2 comments · Fixed by #5516
Labels
area/manifest Issues about infrastructure-as-code templates. type/enhancement Issues that are improvements for existing features. type/request Issues that are created by customers.

Comments

@Lou1415926
Copy link
Contributor

Today users can use ${GIT_SHA} in manifest to substitute ${GIT_SHA} with the value of the shell environment variable GIT_SHA. However, there is no way to escape it. It'd be nice if we don't substitute the value if we see for example \${GIT_SHA}.

Related: #5501 (comment)
@Lou1415926 Lou1415926 added type/enhancement Issues that are improvements for existing features. area/manifest Issues about infrastructure-as-code templates. type/request Issues that are created by customers. labels Dec 5, 2023
@bencehornak-gls
Copy link

@Lou1415926 is your feature request what is being implemented in #5516?

@iamhopaul123
Copy link
Contributor

Hello @bencehornak-gls. Yes, I think so.

@bencehornak bencehornak mentioned this issue Dec 12, 2023
Merged
@mergify mergify bot closed this as completed in #5516 Dec 21, 2023
mergify bot pushed a commit that referenced this issue Dec 21, 2023
@bencehornak
feat: allow variable escaping in manifest (#5516)
6baf5b9 
Allows escaping of interpolated variables:

```yaml
command: echo hello \${name}
variable:
  name: world
```

Fixes #5501, fixes #5532

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/manifest Issues about infrastructure-as-code templates. type/enhancement Issues that are improvements for existing features. type/request Issues that are created by customers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: allow variable escaping in manifest bencehornak/copilot-cli
3 participants
@iamhopaul123 @Lou1415926 @bencehornak-gls