-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow variable escaping in manifest #5516
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## mainline #5516 +/- ##
============================================
- Coverage 70.04% 70.03% -0.01%
============================================
Files 302 302
Lines 46493 46498 +5
Branches 301 301
============================================
+ Hits 32565 32566 +1
- Misses 12345 12348 +3
- Partials 1583 1584 +1 ☔ View full report in Codecov by Sentry. |
🍕 Here are the new binary sizes!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slick! Thank you for your contribution 🙇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!!
Will this fix resolve env variables from container environment? I need to do environment variable substitution from a value from secret.
|
Hello @ShanikaEdiriweera, I think your use case should be covered by this fix. |
Allows escaping of interpolated variables:
Fixes #5501, fixes #5532
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.