-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add utility methods for checking docker container state #5488
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## mainline #5488 +/- ##
============================================
- Coverage 70.02% 70.01% -0.02%
============================================
Files 302 302
Lines 46109 46169 +60
Branches 309 309
============================================
+ Hits 32290 32325 +35
- Misses 12254 12273 +19
- Partials 1565 1571 +6 ☔ View full report in Codecov by Sentry. |
🍕 Here are the new binary sizes!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are extremely easy to understand, looks great!
change error msg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is part 2 of implementation of container dependencies
adding utility methods for checking different states of a container.
In the next PR will be to call these methods based of dependencies of each container in orchestrator pkg.