Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add utility methods for checking docker container state #5488

Merged
merged 8 commits into from
Dec 3, 2023

Conversation

KollaAdithya
Copy link
Contributor

@KollaAdithya KollaAdithya commented Nov 16, 2023

This is part 2 of implementation of container dependencies
adding utility methods for checking different states of a container.
In the next PR will be to call these methods based of dependencies of each container in orchestrator pkg.

@KollaAdithya KollaAdithya requested a review from a team as a code owner November 16, 2023 19:46
@KollaAdithya KollaAdithya requested review from huanjani and removed request for a team November 16, 2023 19:46
@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2023

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (7c79727) 70.02% compared to head (df54cf9) 70.01%.

Files Patch % Lines
internal/pkg/docker/dockerengine/dockerengine.go 66.19% 18 Missing and 6 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           mainline    #5488      +/-   ##
============================================
- Coverage     70.02%   70.01%   -0.02%     
============================================
  Files           302      302              
  Lines         46109    46169      +60     
  Branches        309      309              
============================================
+ Hits          32290    32325      +35     
- Misses        12254    12273      +19     
- Partials       1565     1571       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 16, 2023

🍕 Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 56656 55192 🥺 +2.65
macOS (arm) 57680 56144 🥺 +2.74
linux (amd) 49672 48440 🥺 +2.54
linux (arm) 48960 47748 🥺 +2.54
windows (amd) 46804 45672 🥺 +2.48

Copy link
Contributor

@CaptainCarpensir CaptainCarpensir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are extremely easy to understand, looks great!

Copy link
Contributor

@iamhopaul123 iamhopaul123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mergify mergify bot merged commit c6aefaf into aws:mainline Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants