Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid panicking by initializing required client for static site #5530

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

Lou1415926
Copy link
Contributor

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@Lou1415926 Lou1415926 requested a review from a team as a code owner December 5, 2023 22:54
@Lou1415926 Lou1415926 requested review from CaptainCarpensir and removed request for a team December 5, 2023 22:54
@codecov-commenter
Copy link

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (b4efb96) 70.00% compared to head (5a44691) 70.00%.

Files Patch % Lines
internal/pkg/cli/init.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           mainline    #5530      +/-   ##
============================================
- Coverage     70.00%   70.00%   -0.01%     
============================================
  Files           302      302              
  Lines         46193    46197       +4     
  Branches        309      309              
============================================
  Hits          32338    32338              
- Misses        12281    12285       +4     
  Partials       1574     1574              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 5, 2023

🍕 Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 56768 55192 🥺 +2.86
macOS (arm) 57764 56144 🥺 +2.89
linux (amd) 49776 48440 🥺 +2.76
linux (arm) 49088 47748 🥺 +2.81
windows (amd) 46904 45672 🥺 +2.70

@mergify mergify bot merged commit f044309 into aws:mainline Dec 5, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants