fix: re-reconcile the nodeclass status #7305
Open
+10
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| return reconcile.Result{}, nil | ||
| // If users have omitted the necessary tags and later add them, we need to reprocess the information. | ||
| // Returning 'ok' in this case means that the nodeclass will remain in an unready state until the component is restarted. | ||
| return reconcile.Result{RequeueAfter: 15 * time.Second}, nil |
There was a problem hiding this comment.
Should we add a test for each of these reconcilers to ensure that we don't return an empty result and instead return a RequeueAfter value?
There was a problem hiding this comment.
im not sure if we need the test, how do u think? if its required?
Pull Request Test Coverage Report for Build 11604399987Details
💛 - Coveralls |
jmdeal
reviewed
Oct 31, 2024
Vacant2333
force-pushed
the
fix-re-reconcile-the-nodeclass-status-2
branch
2 times, most recently
from
294042e
to
e3a509a
Compare
|
@jmdeal @jonathan-innis hi, can u help me review again, i have resolve the comments, thank u! |
|
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
Signed-off-by: Vacant2333 <[email protected]>
Vacant2333
force-pushed
the
fix-re-reconcile-the-nodeclass-status-2
branch
from
e3a509a
to
12f3328
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
Description
if users omit the necessary tags and later add them, we need to reprocess the information
How was this change tested?
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.