Let Postgres start if clientauth hits an error #259
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we block Postgres from starting if clientauth cannot initialize its background workers. This causes more downtime and headache than necessary. Instead, use a flag to track whether clientauth hit an error initializing and effectively disable the feature if so, emitting warnings to the database log.
|
More generally, what's the right behavior? If a user wants to start with client_auth hook and they're relying on this feature to authenticate logins, is there a reason they would want the database to start as opposed to fixing the issue? |
|
Good point, closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: Currently we block Postgres from starting if clientauth cannot initialize its background workers. This causes more downtime and headache than necessary. Instead, use a flag to track whether clientauth hit an error initializing and effectively disable the feature if so, emitting warnings to the database log.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.