mixedCase now works in pgtle.clientauth_users_to_skip as intended #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -176,6 +177,9 @@ | |||
| $node->command_ok( | |||
| ['psql', '-U', 'testuser2', '-c', 'select;'], | |||
| "clientauth function does not reject testuser2 when testuser2 is in pgtle.clientauth_users_to_skip"); | |||
| $node->command_ok( | |||
| ['psql', '-U', 'testUser3', '-c', 'select;'], | |||
| "clientauth function does not reject testUser3 when testUser3 is in pgtle.clientauth_users_to_skip"); | |||
There was a problem hiding this comment.
Please a add a test for mixed case clientauth_databases_to_skip as well
|
please investigate why CI is not passing |
|
I think having something like |
…th_databases_to_skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Clientauth skip lists do not work when user/database names are mixed case #265
Description of changes: mixedCase now works in pgtle.clientauth_users_to_skip as intended.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.