Skip to content

Commit

Permalink
pr feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
camshaft committed Oct 31, 2024
1 parent a82ed92 commit a682947
Show file tree
Hide file tree
Showing 5 changed files with 428 additions and 71 deletions.
30 changes: 24 additions & 6 deletions dc/s2n-quic-dc/events/map.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@
struct PathSecretMapInitialized {
/// The capacity of the path secret map
capacity: usize,

/// The port that the path secret is listening on
control_socket_port: u16,
}

#[event("path_secret_map:uninitialized")]
Expand All @@ -17,9 +14,6 @@ struct PathSecretMapUninitialized {
/// The capacity of the path secret map
capacity: usize,

/// The port that the path secret is listening on
control_socket_port: u16,

/// The number of entries in the map
entries: usize,
}
Expand Down Expand Up @@ -92,6 +86,14 @@ struct UnknownPathSecretPacketRejected<'a> {
credential_id: &'a [u8],
}

#[event("path_secret_map:unknown_path_secret_packet_dropped")]
#[subject(endpoint)]
/// Emitted when an UnknownPathSecret packet was dropped due to a missing entry
struct UnknownPathSecretPacketDropped<'a> {
peer_address: SocketAddress<'a>,
credential_id: &'a [u8],
}

#[event("path_secret_map:replay_definitely_detected")]
#[subject(endpoint)]
/// Emitted when credential replay was definitely detected
Expand Down Expand Up @@ -143,6 +145,14 @@ struct ReplayDetectedPacketRejected<'a> {
credential_id: &'a [u8],
}

#[event("path_secret_map:replay_detected_packet_dropped")]
#[subject(endpoint)]
/// Emitted when an ReplayDetected packet was dropped due to a missing entry
struct ReplayDetectedPacketDropped<'a> {
peer_address: SocketAddress<'a>,
credential_id: &'a [u8],
}

#[event("path_secret_map:stale_key_packet_sent")]
#[subject(endpoint)]
/// Emitted when an StaleKey packet was sent
Expand Down Expand Up @@ -174,3 +184,11 @@ struct StaleKeyPacketRejected<'a> {
peer_address: SocketAddress<'a>,
credential_id: &'a [u8],
}

#[event("path_secret_map:stale_key_packet_dropped")]
#[subject(endpoint)]
/// Emitted when an StaleKey packet was dropped due to a missing entry
struct StaleKeyPacketDropped<'a> {
peer_address: SocketAddress<'a>,
credential_id: &'a [u8],
}
Loading

0 comments on commit a682947

Please sign in to comment.