Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: add doc diff #1188

Merged
merged 1 commit into from
Feb 18, 2022
Merged

tools: add doc diff #1188

merged 1 commit into from
Feb 18, 2022

Conversation

camshaft
Copy link
Contributor

@camshaft camshaft commented Feb 18, 2022

Description of changes:

This change adds a docdiff tool to track public API changes with a .snap file. The tool generates the crate documentation with cargo doc and scrapes the HTML files for all of the exported structs, enums, traits, etc. and compares it against the api.snap file in the crate. This will ensure nothing in the public API changes without an explicit cargo insta review.

I tried getting semverver to work but it panicked in a few places and doesn't seem actively maintained (See #18)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@camshaft camshaft force-pushed the camshaft/docdiff branch 10 times, most recently from e8664b9 to 71f16c1 Compare February 18, 2022 21:41
@camshaft camshaft marked this pull request as ready for review February 18, 2022 21:46
Copy link
Contributor

@WesleyRosenblum WesleyRosenblum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@camshaft camshaft merged commit e0d4c24 into main Feb 18, 2022
@camshaft camshaft deleted the camshaft/docdiff branch February 18, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants