feat(s2n-quic-platform): add unstable option for multiple sockets #1867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WesleyRosenblum
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
While using the probes from #1866, I noticed that the sendmmsg syscall could take quite a long time (upwards of 1ms), especially when the total number of messages being sent was high.
One thing that did help was to use the multithreaded runtime and multiple TX sockets. This does increase CPU usage but also increases throughput and minimizes latency, since we're executing multiple syscalls in parallel, each with smaller buffers.
Call-outs:
I've made this an unstable option for now, in case we want to change how the socket initialization works. Currently, it just calls
try_clone()on the single socket for each task, which might cause issues later down the line (not sure).Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.