fix(netbench): correctly handle stream shutdown in duplex #1898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
commented
Aug 8, 2023
| @@ -125,22 +125,31 @@ impl<T: AsyncRead + AsyncWrite> super::Connection for Connection<T> { | |||
|
|
|||
| match self.inner.as_mut().poll_read(cx, &mut buf) { | |||
| Poll::Ready(_) => { | |||
| if buf.filled().is_empty() && self.stream_opened { | |||
There was a problem hiding this comment.
The main issue seems to be coming from the fact that we're checking && self.stream_opened here. If this poll_receive function is called after it's closed, then we will never exit from the loop
goatgoose
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
After merging #1883, the s2n-tls netbench driver has been consistently failing on the ping test. Digging in a bit deeper on it, it looks like the
Duplexdriver wasn't correctly handling cases where the stream shut down and it got into an infinite loop.This change fixes the receive to handle all of the error cases correctly.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.