Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): update rustls requirement from 0.20 to 0.21 #1924

Merged
merged 5 commits into from
Aug 24, 2023

Conversation

WesleyRosenblum
Copy link
Contributor

@WesleyRosenblum WesleyRosenblum commented Aug 22, 2023

Resolved issues:

resolves #1836

Description of changes:

Updates the requirements on rustls to permit the latest version.

Callouts

I've pinned the test dependency backtrace (used by bolero) to 0.3.68 as the latest version updates its dependency on addr2line to a version that requires Rust 1.65.0. Would this make more sense to do within bolero? (see camshaft/bolero#169)

I've removed the patch for webpki introduced in #1837 as a workaround to get the amplification limit interop test to succeed (see #1836) and instead disable cert verification in rustls for this interop test

Testing:

Interop testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@WesleyRosenblum WesleyRosenblum marked this pull request as draft August 23, 2023 00:42
@WesleyRosenblum WesleyRosenblum merged commit b685748 into main Aug 24, 2023
131 checks passed
@WesleyRosenblum WesleyRosenblum deleted the WesleyRosenblum/rustlsupgrade branch August 24, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

s2n-quic-rustls interop fails due to limited cert chain depth in webpki crate
2 participants