feat(s2n-quic-dc): export event module #2360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark-Simulacrum
approved these changes
Oct 31, 2024
| #[event("application:write")] | ||
| pub struct ApplicationRead { | ||
| /// The number of bytes that the application tried to read | ||
| len: usize, |
There was a problem hiding this comment.
nit: maybe capacity is a better name for this field, since I presume it's how much space the application provided us?
There was a problem hiding this comment.
yeah that's a good call. i can fix when i wire it up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change exports the
eventmodule from thes2n-quic-dccrate. There were a few issues with the code gen that wasn't caught, since it wasn't being exported previously, so I fixed those issues as well.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.