feat(s2n-quic-dc): implement cache events #2386
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change adds events around cache hits for path secrets. This should give a good idea of how often flows are needing to wait for handshakes to complete before continuing.
In adding these, I've also included a TOCTOU issue I've been wanting to address for awhile. Now, we return the path secret entry atomically when checking if we have an entry or not.
Call-outs:
The
get_by_addr
method were missing the same checks that thecontains
method has aroundrequested_handshakes.contains(peer)
, so I've added that.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.