Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(s2n-quic-dc): implement cache events #2386

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Conversation

camshaft
Copy link
Contributor

@camshaft camshaft commented Nov 22, 2024

Description of changes:

This change adds events around cache hits for path secrets. This should give a good idea of how often flows are needing to wait for handshakes to complete before continuing.

In adding these, I've also included a TOCTOU issue I've been wanting to address for awhile. Now, we return the path secret entry atomically when checking if we have an entry or not.

Call-outs:

The get_by_addr method were missing the same checks that the contains method has around requested_handshakes.contains(peer), so I've added that.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@camshaft camshaft force-pushed the camshaft/dc-cache-tracking branch from c2355db to 4fbbef1 Compare November 22, 2024 21:34
dc/s2n-quic-dc/src/path/secret/map/state.rs Outdated Show resolved Hide resolved
@camshaft camshaft marked this pull request as ready for review November 22, 2024 21:37
@camshaft camshaft enabled auto-merge (squash) November 22, 2024 21:44
@camshaft camshaft merged commit c84ba19 into main Nov 22, 2024
129 of 130 checks passed
@camshaft camshaft deleted the camshaft/dc-cache-tracking branch November 22, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants