Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add more awslc-fips-2022 testing #5049

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lrstewart
Copy link
Contributor

Release Summary:

Description of changes:

I noticed while messing with the fips logic for the openssl-3-fips work that we're missing some awslc-fips testing:

  • fuzz_batch tests awslc, but not awslc-fips or awslc-fips-2022
  • sanitizer tests awslc, but not awslc-fips or awslc-fips-2022
  • valgrind tests awslc and awslc-fips, but not awslc-fips-2022 (the newer version)

awslc is an important libcrypto and fips is a common use case, so we need to make sure we thoroughly test the latest fips version of awslc. Wherever we test with different libcryptos, we should be testing with awslc-fips-2022.

I searched our buildspecs for "S2N_LIBCRYPTO:" to get an idea of which specs used which libcryptos. I added awslc-fips-2022 anywhere it was missing.

Testing:

This adds more testing, which should pass in the CI.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the s2n-core team label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant