Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) Feature: fix ENABLE_MULTI_MODEL setting #135

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

taylorfturner
Copy link

Issue #, if available: N/A

Description of changes: Resolving how ENABLE_MULTI_MODEL is set in the code.

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • [] I used the commit message format described in CONTRIBUTING
  • [] I have used the regional endpoint when creating S3 and/or STS clients (if appropriate)
  • [] I have updated any necessary documentation, including READMEs

Tests

  • [] I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • [] I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HammySession
Copy link

Found this code, affects deployment of pytorch_huggingface_inference, by never allowing the new handler to run and only using the default handler unless SAGEMAKER_MULTI_MODEL is set to False.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants