-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix ValueError when updating a data quality monitoring schedule #5002
base: master
Are you sure you want to change the base?
fix: fix ValueError when updating a data quality monitoring schedule #5002
Conversation
Hi @zhaoqizqwang could you please review when you get the chance? Thanks 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add some unit tests
To fix the |
Integ test failure logs: https://github.com/aws/sagemaker-python-sdk/actions/runs/13127360276/job/36689546917?pr=5002 |
Issue #, if available: #5001
Description of changes: Fix ValueError raised when updating a data quality monitoring schedule with a cron_schedule_expression of 'NOW'.
Testing done:
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_base
to create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.