Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ssh configuration in buildspec and update format #22

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove ssh configuration in buildspec and update format #22

wants to merge 2 commits into from

Conversation

yangaws
Copy link
Contributor

@yangaws yangaws commented May 9, 2019

Issue #, if available:

Description of changes:

  1. Update buildspec with each command per line to avoid exception being swallowed by codebuild
  2. Remove ssh configuration in buildspec. This is now configured in remote test script.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@yangaws yangaws requested a review from icywang86rui May 9, 2019 07:28
@jesterhazy
Copy link
Contributor

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

jesterhazy
jesterhazy suggested changes May 9, 2019
View reviewed changes
Copy link
Contributor

@jesterhazy jesterhazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these changes look ok, but there are 3 separate pytest invocations inside the integ test if block. codebuild will miss failures on the first 2 invocations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesterhazy jesterhazy jesterhazy requested changes

@icywang86rui icywang86rui Awaiting requested review from icywang86rui

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yangaws @jesterhazy