Skip to content

Commit

Permalink
fix backwards compatibility check (#1361)
Browse files Browse the repository at this point in the history
  • Loading branch information
nakulj authored Jul 12, 2024
1 parent 57dcddf commit 3b5c59e
Showing 1 changed file with 12 additions and 3 deletions.
15 changes: 12 additions & 3 deletions .github/scripts/backwards_compatibility_check.sh
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,16 @@ find_removed_methods() {
then
echo "New minor release is being performed. Ignoring changes in classes marked with @KinesisClientInternalApi annotation."
fi
local latest_classes=$(jar tf $LATEST_JAR | grep .class | tr / . | sed 's/\.class$//')
local latest_classes=$(
jar tf $LATEST_JAR |
grep .class |
tr / . |
sed 's/\.class$//' |
# skip generated proto classes since these have a lot of inherited methods
# that are not outputted by javap. besides, generated java code is not a
# good indicator of proto compatibility- it will not capture reserved
# tags or deprecated fields.
grep -v 'software\.amazon\.kinesis\.retrieval\.kpl\.Messages')
for class in $latest_classes
do
if (is_kinesis_client_internal_api "$class" && is_new_minor_release) || is_non_public_class "$class"
Expand All @@ -83,7 +92,7 @@ find_removed_methods() {
local removed_methods=$(diff <(echo "$LATEST_METHODS") <(echo "$CURRENT_METHODS") | grep '^<')

# ignore synthetic access methods - these are not available to users and will not break backwards compatibility
removed_methods=$(echo "$removed_methods" | grep -v "access\$[0-9]00")
removed_methods=$(echo "$removed_methods" | grep -v "access\$[0-9]\+")

if [[ "$removed_methods" != "" ]]
then
Expand Down Expand Up @@ -116,4 +125,4 @@ main() {
get_backwards_compatible_result
}

main
main

0 comments on commit 3b5c59e

Please sign in to comment.