Skip to content

Commit

Permalink
Bump PIC version and small stack size test (#461)
Browse files Browse the repository at this point in the history
* Bump PIC and small stack size test

* Bump configure-aws-creds to v4

* Move AWS credentials to after build

* Add permissions

* Cd build

* Use preinstalled toolchain

* Check for seg fault message

* Check exit code
  • Loading branch information
sirknightj authored Nov 20, 2024
1 parent 63d63e5 commit 052077f
Show file tree
Hide file tree
Showing 2 changed files with 36 additions and 1 deletion.
35 changes: 35 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -487,3 +487,38 @@ jobs:
mkdir build && cd build
cmake .. -DBUILD_STATIC=ON
make
linux-thread-size-check:
runs-on: ubuntu-latest
permissions:
id-token: write
contents: read
steps:
- name: Clone repository
uses: actions/checkout@v3
- name: Configure AWS Credentials
uses: aws-actions/configure-aws-credentials@v4
with:
role-to-assume: ${{ secrets.AWS_ROLE_TO_ASSUME }}
role-session-name: ${{ secrets.AWS_ROLE_SESSION_NAME }}
aws-region: ${{ secrets.AWS_REGION }}
role-duration-seconds: 10800
- name: Build Repository
run: |
mkdir build && cd build
cmake .. -DBUILD_TEST=TRUE -DKVS_DEFAULT_STACK_SIZE=65536
make -j$(nproc)
- name: Run tests with expected failure
run: |
set +e
cd build
./tst/producer_test --gtest_filter="ProducerClientBasicTest.*"
TEST_EXIT_CODE=$?
# 128 (abnormal exit) + 11 (segmentation fault) = 139
if [ $TEST_EXIT_CODE -ne 139 ]; then
echo "Unexpected exit code: $TEST_EXIT_CODE"
exit 1
fi
echo "Test exited as expected with code $TEST_EXIT_CODE."
shell: bash
2 changes: 1 addition & 1 deletion CMake/Dependencies/libkvspic-CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ include(ExternalProject)
# clone repo only
ExternalProject_Add(libkvspic-download
GIT_REPOSITORY https://github.com/awslabs/amazon-kinesis-video-streams-pic.git
GIT_TAG v1.1.0
GIT_TAG v1.2.0
SOURCE_DIR "${CMAKE_CURRENT_BINARY_DIR}/kvspic-src"
BINARY_DIR "${CMAKE_CURRENT_BINARY_DIR}/kvspic-build"
CMAKE_ARGS
Expand Down

0 comments on commit 052077f

Please sign in to comment.