Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.5.4 #464

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Release 1.5.4 #464

merged 3 commits into from
Nov 22, 2024

Conversation

sirknightj
Copy link
Contributor

@sirknightj sirknightj commented Nov 20, 2024

Issue #, if available:

  • N/A

What was changed?

  • Bump the PIC version from 1.1.0 to 1.2.0
  • Update the CI
    • Update runner images to the latest
    • Update configure-aws-credentials from v1 to v4
  • Disable warnings for building LWS, needed for Clang 14 compilation (due to unused variable in LWS code).
  • New job to check that stack size default is honored (see PIC 1.2.0 release)

Why was it changed?

  • To add configurability option for thread stack sizes.

How was it changed?

  • The changes were done in PIC, which contains the actual thread creation logic.

What testing was done for the changes?

  • The CI new job checks that the stack size default is honored, which is passing.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

* Bump the runner images

* Bump configure-aws-credentials to v4.

* Downgrade to clang 11

* Sanitzer options

* Go back to clang 14. Turn off warnings as error for libwebsockets

* ON -> 1

* Wno-error via CFLAGS

* Pass C_FLAGS directly
* Bump PIC and small stack size test

* Bump configure-aws-creds to v4

* Move AWS credentials to after build

* Add permissions

* Cd build

* Use preinstalled toolchain

* Check for seg fault message

* Check exit code
@sirknightj sirknightj marked this pull request as ready for review November 20, 2024 20:59
@sirknightj sirknightj merged commit 5fb356e into master Nov 22, 2024
39 checks passed
@sirknightj sirknightj deleted the develop branch November 22, 2024 17:44
sirknightj added a commit that referenced this pull request Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants