Skip to content

Commit

Permalink
Fixed incorrect code snippets in docstring (#62)
Browse files Browse the repository at this point in the history
  • Loading branch information
byronlin13 authored Jun 4, 2021
1 parent e28b769 commit eb7b182
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 14 deletions.
15 changes: 10 additions & 5 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,16 +1,21 @@
# 2.3.0
# 2.3.1

### :bug: Fixed
* Fix incorrect code snippet in docstrings.

# [2.3.0](https://github.com/awslabs/amazon-qldb-driver-java/releases/tag/v2.3.0)

### :hammer_and_wrench: Improvements
* Add `httpClientBuilder` attribute to `QldbDriverBuilder` to support use of custom HTTP clients.
* The following code demonstrates how to use it:
```
QldbSessionClientBuilder sessionClientBuilder = QldbSessionClient.builder();
QldbDriverBuilder builder = QldbDriver

QldbDriver qldbDriver = QldbDriver
.builder()
.ledger(ledger);
.ledger(ledger)
.maxConcurrentTransactions(poolLimit)
.transactionRetryPolicy(TransactionRetryPolicy.builder().maxNumberOfRetries(retryLimit).build());
.transactionRetryPolicy(TransactionRetryPolicy.builder().maxNumberOfRetries(retryLimit).build())
.sessionClientBuilder(sessionClientBuilder)
.httpClientBuilder(ApacheHttpClient.builder().maxConnections(maxConnections))
.build();
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<modelVersion>4.0.0</modelVersion>
<groupId>software.amazon.qldb</groupId>
<artifactId>amazon-qldb-driver-java</artifactId>
<version>2.3.0</version>
<version>2.3.1</version>
<packaging>jar</packaging>

<name>${project.groupId}:${project.artifactId}</name>
Expand Down
16 changes: 8 additions & 8 deletions src/main/java/software/amazon/qldb/QldbDriverBuilder.java
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,14 @@
* <pre>{@code
* QldbSessionClientBuilder sessionClientBuilder = QldbSessionClient.builder();
*
* QldbDriverBuilder builder = QldbDriver
* .builder()
* .ledger(ledger);
* .maxConcurrentTransactions(poolLimit)
* .transactionRetryPolicy(TransactionRetryPolicy.builder().maxNumberOfRetries(retryLimit).build());
* .sessionClientBuilder(sessionClientBuilder)
* .httpClientBuilder(ApacheHttpClient.builder().maxConnections(maxConnections))
* .build();
* QldbDriver qldbDriver = QldbDriver
* .builder()
* .ledger(ledger)
* .maxConcurrentTransactions(poolLimit)
* .transactionRetryPolicy(TransactionRetryPolicy.builder().maxNumberOfRetries(retryLimit).build())
* .sessionClientBuilder(sessionClientBuilder)
* .httpClientBuilder(ApacheHttpClient.builder().maxConnections(maxConnections))
* .build();
* }</pre>
*
*/
Expand Down

0 comments on commit eb7b182

Please sign in to comment.