Fix CMake option for choosing MSVC runtime library #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graebm
changed the title
SergeyRyabinin
approved these changes
Aug 31, 2023
…ead. STATIC_CRT is confusingly named, since we refer to this codebase as "CRT", but this option refers to Microsoft's C-runtime library.
graebm
changed the title
graebm
added a commit
to awslabs/aws-crt-cpp
that referenced
this pull request
Sep 6, 2023
**Issue:** The `-DSTATIC_CRT=ON` CMake option for choosing the MSVC runtime library didn't affect submodules. Also it's a terribly named option, since we refer to this codebase as "CRT". **Description of changes:** 1) Pick up this fix in the submodules: awslabs/aws-c-common#1054 2) ~STATIC_CRT~ is deprecated, use new `AWS_STATIC_MSVC_RUNTIME_LIBRARY` option instead. 3) Use `$<CONFIG>` generator expressions, instead of checking `${CMAKE_BUILD_TYPE}`, to better support multi-config generators like Visual Studio. See: https://cmake.org/cmake/help/v3.22/manual/cmake-buildsystem.7.html#build-configurations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Building with
-DSTATIC_CRT=ONdidn't actually do anything.Diagnosis:
Our CMake logic relied on
${CMAKE_BUILD_TYPE}being set, but for multi-config generators like Visual Studio${CMAKE_BUILD_TYPE}is ignored and most users (and IDEs) don't bother setting it.Description of changes:
$<CONFIG>generator expressions, instead of checking${CMAKE_BUILD_TYPE}, to support multi-config generators like Visual Studio. See: https://cmake.org/cmake/help/v3.22/manual/cmake-buildsystem.7.html#build-configurations.STATIC_CRToption, replace withAWS_STATIC_MSVC_RUNTIME_LIBRARY=OFF|ON.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.