Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Megalinter v8.1 #738

Merged
merged 5 commits into from
Mar 3, 2025
+25 −29
Merged

Megalinter v8.1 #738

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7ea3129
Moving ml back to latest v7
Jun 12, 2024
65d0114
Moving back to latest megalinter, table-formatting and consistent emp…
javydekoning Jun 12, 2024
946f0b0
Merge branch 'awslabs:master' into ml-7.12
javydekoning Oct 25, 2024
51131aa
Moving ml to v8
Oct 25, 2024
920ec82
Moving ml to v8.1
Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Moving back to latest megalinter, table-formatting and consistent emp… 
…hasis usage in CHANGELOG.md
  • Loading branch information
@javydekoning
javydekoning committed Jun 12, 2024
commit 65d01149a9959ae807b0f04e08cd174371cdf8ec
2 changes: 1 addition & 1 deletion .mega-linter.yml
View file
Original file line number Diff line number Diff line change
@@ -31,7 +31,7 @@ FILEIO_REPORTER: false

# Install plugin for list handling.
JSON_PRETTIER_PRE_COMMANDS:
- command: "npm install prettier-plugin-multiline-arrays@3.0.4"
- command: "npm install prettier-plugin-multiline-arrays@3.0.6"
cwd: "workspace"

CLOUDFORMATION_CFN_LINT_CONFIG_FILE: '.cfnlintrc'
46 changes: 23 additions & 23 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -349,30 +349,30 @@ IAM permission boundaries. Where applicable, the roles received a new prefix.
This makes it easier to identify what part of ADF relies on those roles and
whom should have access to assume the role or modify it.

| Previous prefix | Previous name | New prefix | New name |
|------------------|---------------------------------------------------------------------|----------------------------|---------------------------------------------------------------|
| / | ${CrossAccountAccessRoleName}-readonly | /adf/organizations/ | adf-organizations-readonly |
| / | adf-update-cross-account-access-role | /adf/bootstrap/ | adf-update-cross-account-access |
| /adf-automation/ | adf-create-repository-role | /adf/pipeline-management/ | adf-pipeline-management-create-repository |
| /adf-automation/ | adf-pipeline-provisioner-generate-inputs | /adf/pipeline-management/ | adf-pipeline-management-generate-inputs |
| /adf-automation/ | adf-pipeline-create-update-rule | /adf/pipeline-management/ | adf-pipeline-management-create-update-rule |
| / | adf-event-rule-${AWS::AccountId}-${DeploymentAccountId}-EventRole-* | /adf/cross-account-events/ | adf-cc-event-from-${AWS::AccountId}-to-${DeploymentAccountId} |
|------------------|---------------------------------------------------------------------|----------------------------|---------------------------------------------------------------|
| Previous prefix | Previous name | New prefix | New name |
|--------------------|-----------------------------------------------------------------------|------------------------------|-----------------------------------------------------------------|
| / | ${CrossAccountAccessRoleName}-readonly | /adf/organizations/ | adf-organizations-readonly |
| / | adf-update-cross-account-access-role | /adf/bootstrap/ | adf-update-cross-account-access |
| /adf-automation/ | adf-create-repository-role | /adf/pipeline-management/ | adf-pipeline-management-create-repository |
| /adf-automation/ | adf-pipeline-provisioner-generate-inputs | /adf/pipeline-management/ | adf-pipeline-management-generate-inputs |
| /adf-automation/ | adf-pipeline-create-update-rule | /adf/pipeline-management/ | adf-pipeline-management-create-update-rule |
| / | adf-event-rule-${AWS::AccountId}-${DeploymentAccountId}-EventRole-* | /adf/cross-account-events/ | adf-cc-event-from-${AWS::AccountId}-to-${DeploymentAccountId} |
| ------------------ | --------------------------------------------------------------------- | ---------------------------- | --------------------------------------------------------------- |

#### ADF Renaming of Resources

| Type | Previous name | New name |
|--------------|-----------------------------------------------|--------------------------------------------------------|
| StateMachine | EnableCrossAccountAccess | adf-bootstrap-enable-cross-account |
| StateMachine | ADFPipelineManagementStateMachine | adf-pipeline-management |
| StateMachine | PipelineDeletionStateMachine-* | adf-pipeline-management-delete-outdated |
| Lambda | DeploymentMapProcessorFunction | adf-pipeline-management-deployment-map-processor |
| Lambda | ADFPipelineCreateOrUpdateRuleFunction | adf-pipeline-management-create-update-rule |
| Lambda | ADFPipelineCreateRepositoryFunction | adf-pipeline-management-create-repository |
| Lambda | ADFPipelineGenerateInputsFunction | adf-pipeline-management-generate-pipeline-inputs |
| Lambda | ADFPipelineStoreDefinitionFunction | adf-pipeline-management-store-pipeline-definition |
| Lambda | ADFPipelineIdentifyOutOfDatePipelinesFunction | adf-pipeline-management-identify-out-of-date-pipelines |
|--------------|-----------------------------------------------|--------------------------------------------------------|
| Type | Previous name | New name |
|----------------|-------------------------------------------------|----------------------------------------------------------|
| StateMachine | EnableCrossAccountAccess | adf-bootstrap-enable-cross-account |
| StateMachine | ADFPipelineManagementStateMachine | adf-pipeline-management |
| StateMachine | PipelineDeletionStateMachine-* | adf-pipeline-management-delete-outdated |
| Lambda | DeploymentMapProcessorFunction | adf-pipeline-management-deployment-map-processor |
| Lambda | ADFPipelineCreateOrUpdateRuleFunction | adf-pipeline-management-create-update-rule |
| Lambda | ADFPipelineCreateRepositoryFunction | adf-pipeline-management-create-repository |
| Lambda | ADFPipelineGenerateInputsFunction | adf-pipeline-management-generate-pipeline-inputs |
| Lambda | ADFPipelineStoreDefinitionFunction | adf-pipeline-management-store-pipeline-definition |
| Lambda | ADFPipelineIdentifyOutOfDatePipelinesFunction | adf-pipeline-management-identify-out-of-date-pipelines |
| -------------- | ----------------------------------------------- | -------------------------------------------------------- |

#### ADF Parameters in AWS Systems Manager Parameter Store

@@ -1208,7 +1208,7 @@ around IAM we have created two new IAM Role that lives on each AWS Account
within the organization. These role are created in the global.yml
*(base stack)* of each account and are used for the following purposes:

**adf-automation-role:**
__adf-automation-role:__

> When creating pipelines in ADF there are certain things that are required to
> be setup on multiple different accounts. For example, the source account
@@ -1222,7 +1222,7 @@ This new role (`adf-automation-role`) is assumed by CodeBuild in the
`aws-deployment-framework-pipelines` pipeline exclusively and cannot be
assumed by the standard *(other)* deployment pipelines.

**adf-readonly-automation-role:**
__adf-readonly-automation-role:__

> When CodeBuild runs as part of a standard deployment pipeline
> *(anything other than `aws-deployment-framework-pipelines`)* it uses the