-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Debug Logs #471
base: master
Are you sure you want to change the base?
Add Debug Logs #471
Conversation
Codecov Report
@@ Coverage Diff @@
## master #471 +/- ##
==========================================
- Coverage 66.25% 65.40% -0.86%
==========================================
Files 173 163 -10
Lines 13275 12942 -333
==========================================
- Hits 8796 8465 -331
+ Misses 4479 4477 -2
Continue to review full report at Codecov.
|
@@ -1 +1 @@ | |||
__version__ = "1.0.8" | |||
__version__ = "1.0.8c0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
@@ -155,6 +156,7 @@ def write_tensor( | |||
tag = tname | |||
tensor_proto = make_tensor_proto(nparray_data=value, tag=tag) | |||
s = Summary(value=[Summary.Value(tag=tag, metadata=smd, tensor=tensor_proto)]) | |||
self.logger.debug(f"smdebug: writing tensor: {tname}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the logger itself handle prepending smdebug as an identifier to each logging message?
@@ -725,6 +727,7 @@ def _remove_fetches_and_callbacks(self, mode): | |||
|
|||
def _prepare_collections_for_tf2(self): | |||
self._prepare_collections() | |||
self.logger.debug("SMDEBUG: Preparing Collections") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Case of "smdebug" is inconsistent. There should be some higher level wrapper that manages prepending "smdebug" so that it isn't expected for the writer of the log to remember to prepend "smdebug".
Description of changes:
Style and formatting:
I have run
pre-commit install
to ensure that auto-formatting happens with every commit.Issue number, if available
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.