Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Debug Logs #471

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add Debug Logs #471

wants to merge 6 commits into from

Conversation

NihalHarish
Copy link
Contributor

Description of changes:

Style and formatting:

I have run pre-commit install to ensure that auto-formatting happens with every commit.

Issue number, if available

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link

codecov-io commented Mar 23, 2021

Codecov Report

Merging #471 (8049b3d) into master (7c5c8c4) will decrease coverage by 0.85%.
The diff coverage is 100.00%.

❗ Current head 8049b3d differs from pull request most recent head 9a023a1. Consider uploading reports for the commit 9a023a1 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #471      +/-   ##
==========================================
- Coverage   66.25%   65.40%   -0.86%     
==========================================
  Files         173      163      -10     
  Lines       13275    12942     -333     
==========================================
- Hits         8796     8465     -331     
+ Misses       4479     4477       -2     
Impacted Files Coverage Δ
smdebug/_version.py 100.00% <100.00%> (ø)
smdebug/core/hook.py 93.58% <100.00%> (+0.21%) ⬆️
smdebug/core/writer.py 88.49% <100.00%> (-1.60%) ⬇️
smdebug/tensorflow/keras.py 89.42% <100.00%> (+0.13%) ⬆️
smdebug/mxnet/graph.py 25.80% <0.00%> (-32.26%) ⬇️
smdebug/mxnet/utils.py 59.37% <0.00%> (-28.13%) ⬇️
...profiler/analysis/utils/profiler_data_to_pandas.py 36.07% <0.00%> (-27.86%) ⬇️
...ler/analysis/notebook_utils/step_timeline_chart.py 0.00% <0.00%> (-21.32%) ⬇️
...debug/profiler/analysis/python_profile_analysis.py 90.90% <0.00%> (-5.79%) ⬇️
...profiler/analysis/notebook_utils/step_histogram.py 0.00% <0.00%> (-4.45%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c5c8c4...9a023a1. Read the comment docs.

@@ -1 +1 @@
__version__ = "1.0.8"
__version__ = "1.0.8c0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

@@ -155,6 +156,7 @@ def write_tensor(
tag = tname
tensor_proto = make_tensor_proto(nparray_data=value, tag=tag)
s = Summary(value=[Summary.Value(tag=tag, metadata=smd, tensor=tensor_proto)])
self.logger.debug(f"smdebug: writing tensor: {tname}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the logger itself handle prepending smdebug as an identifier to each logging message?

@@ -725,6 +727,7 @@ def _remove_fetches_and_callbacks(self, mode):

def _prepare_collections_for_tf2(self):
self._prepare_collections()
self.logger.debug("SMDEBUG: Preparing Collections")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Case of "smdebug" is inconsistent. There should be some higher level wrapper that manages prepending "smdebug" so that it isn't expected for the writer of the log to remember to prepend "smdebug".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants