Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement unit and e2e tests #32

Merged
merged 5 commits into from
Mar 26, 2018
Merged

Implement unit and e2e tests #32

merged 5 commits into from
Mar 26, 2018

Conversation

axe312ger
Copy link
Owner

@axe312ger axe312ger commented Mar 22, 2018

This PR adds basic unit and e2e tests to ensure we won't accidentally break functionality while implementing #30

What the pr does:

  • first restructuring of the source code to improve readability and prepare for further changes
  • adds unit tests for core functionality and the node api (mostly snapshots, more precise tests follow later on in other PRs)
  • e2e tests for cli usage

Would be great if @technopagan could enable travis for this repo now :)

@axe312ger axe312ger requested a review from efegurkan March 22, 2018 10:43
@axe312ger axe312ger force-pushed the test/jest branch 3 times, most recently from 7407700 to 5769162 Compare March 22, 2018 13:42
@codecov-io
Copy link

codecov-io commented Mar 22, 2018

Codecov Report

❗ No coverage uploaded for pull request base (next@84ef7d4). Click here to learn what that means.
The diff coverage is 95.52%.

Impacted file tree graph

@@           Coverage Diff           @@
##             next      #32   +/-   ##
=======================================
  Coverage        ?   86.53%           
=======================================
  Files           ?        5           
  Lines           ?      104           
  Branches        ?       15           
=======================================
  Hits            ?       90           
  Misses          ?       11           
  Partials        ?        3
Impacted Files Coverage Δ
src/utils/primitive.js 100% <100%> (ø)
src/utils/svg.js 100% <100%> (ø)
src/utils/helpers.js 100% <100%> (ø)
src/index.js 71.73% <70%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84ef7d4...1318625. Read the comment docs.

@efegurkan
Copy link
Collaborator

LGTM, feel free to merge 👍

@axe312ger axe312ger merged commit bdf9796 into next Mar 26, 2018
@axe312ger axe312ger deleted the test/jest branch March 26, 2018 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants