implement async API #42
Conversation
src/utils/primitive.js
Outdated
| const PRIMITIVE_TEMP_FILE = os.tmpdir() + '/primitive_tempfile.svg' | ||
| const PRIMITIVE_TEMP_FILE = path.resolve( | ||
| os.tmpdir(), | ||
| `primitive-tempfile-${new Date().getTime()}.svg` |
There was a problem hiding this comment.
I recommend using https://www.npmjs.com/package/tempfile here to avoid possible tempfile clashes when many files are worked on in parallel
There was a problem hiding this comment.
Cool idea!! Maybe even https://github.com/sindresorhus/tempy since it is recommended in the tempfile README.md :)
|
The tests failures looks odd, the first about missing localStorage and the second about syntax errors in golang's draw module. Maybe the latter has resolved itself since the tests were run, but the former I'm not sure about. Either way it would be really sweet if this got merged 🙌 |
additionally replaces travis with circle ci
hafizalfaza
force-pushed
the
refactor/async
branch
from
3531a59 to
3d828d5
Compare
Codecov Report
@@ Coverage Diff @@
## next #42 +/- ##
====================================
Coverage ? 0%
====================================
Files ? 5
Lines ? 100
Branches ? 11
====================================
Hits ? 0
Misses ? 89
Partials ? 11
Continue to review full report at Codecov.
|
|
@hafizalfaza your commit failed on CircleCI We need to keep require in the bundle-vendor.js since it is executed by node directly without babel involved. |
|
Alright, looks good for now. lets continue in another PR/branch :) |
This is hopefully the last huge rewrite on the road to v1 #35 #30
shouldThrowsince it was just clutterWill fix #5 when done