test: update test for contract config #505
Conversation
| @@ -341,7 +341,6 @@ | |||
| "tokenSymbol": "BNB", | |||
| "chainType": "evm", | |||
| "contracts": { | |||
| "AxelarGateway": {}, | |||
There was a problem hiding this comment.
is this still in an invalid state? i thought we finished the deployment
There was a problem hiding this comment.
Found this update: https://interoplabs.slack.com/archives/C02QRPRH22X/p1721684972174219
@talalashraf we can try to recover it if you still have a log?
There was a problem hiding this comment.
As per our discussion will create tickets to deploy binance and centrifuge on stagenet.
| @@ -18,15 +18,15 @@ export const contractValueSchema = { | |||
| properties: { | |||
| address: { type: 'string' }, | |||
| }, | |||
| required: ['address'], | |||
There was a problem hiding this comment.
for every contract, if it exists under contracts key, it's address should be included and checked
There was a problem hiding this comment.
Okay I will be reverting address check. But for InterchainTokenService on hedera [here], address check fails. Shouldn't we Ideally remove "skip": true ?
There was a problem hiding this comment.
See the usage of "skip": true in the scripts. For now, you can add an empty "address" or so there. Feel free to implement a better solution and then we can remove it
| }; | ||
|
|
||
| export const contractSchema = { | ||
| id: '/info.chains.contracts', | ||
| type: 'object', | ||
| patternProperties: { | ||
| // PascalName e.g. 'AxelarGasService', 'AxelarGateway' etc. | ||
| '\b[A-Z][a-z]*([A-Z][a-z]*)*\b': { |
There was a problem hiding this comment.
This regex was not working earlier, therefore the checks were passing until now.
| @@ -18,15 +18,15 @@ export const contractValueSchema = { | |||
| properties: { | |||
| address: { type: 'string' }, | |||
| }, | |||
| required: ['address'], | |||
There was a problem hiding this comment.
See the usage of "skip": true in the scripts. For now, you can add an empty "address" or so there. Feel free to implement a better solution and then we can remove it
https://axelarnetwork.atlassian.net/browse/AXE-7213