refactor: manage keepers in app.go in a map for better organization #2013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgorenflo
requested review from
jcs47,
haiyizxx,
milapsheth and
cjcobb23
as code owners
cgorenflo
commented
Nov 2, 2023
cgorenflo
commented
Nov 2, 2023
fish-sammy
approved these changes
Nov 2, 2023
cgorenflo
force-pushed
the
use-keeper-map
branch
from
4933b86 to
9ba65a4
Compare
This commit refactors the management of keepers in app.go to a map instead of individual variables. This decouples the initialization steps of the individual components, so they can be more easily extracted in subsequent refactorings.
cgorenflo
force-pushed
the
use-keeper-map
branch
from
eeee988 to
e6c2fcf
Compare
haiyizxx
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the management of keepers in app.go to a map instead of individual variables. This decouples the initialization steps of the individual components, so they can be more easily extracted in subsequent refactorings.